search

Sasszem / 13

Recreation of a simple but addictive game
MIT License
0 stars 0 forks source link

Change game to use roman numerals #36

Closed Sasszem closed 4 years ago

Sasszem commented 4 years ago

Closes #30

Sasszem commented 4 years ago

Updated, please review again, @Btimes2! Also closes #45

Btimes2 commented 4 years ago

I see you decided to always write the game's name with Roman numerals :)

Sasszem commented 4 years ago

Perfect implementation. I only wonder why you did not include the Roman numerals above 15. Is 16 so hard to reach that no user will ever reasonably get it?

The game ends on 13, so yea, no one will get there without cheating...

Sasszem commented 4 years ago

I see you decided to always write the game's name with Roman numerals :)

I forgot about that. Shall I make that also optional?

Btimes2 commented 4 years ago

Perfect implementation. I only wonder why you did not include the Roman numerals above 15. Is 16 so hard to reach that no user will ever reasonably get it?

The game ends on 13, so yea, no one will get there without cheating...

In that case it is okay.

I see you decided to always write the game's name with Roman numerals :)

I forgot about that. Shall I make that also optional?

Yeah, what if the game title text would be only XIII if the Roman numbers option is turned on? For the sake of those poor people without humor.

Btimes2 commented 4 years ago

I tested it, it works nicely. I did not push the merge button yet bc I don't really understand how it works, and I am also not sure about the direction of this merge (master INTO roman?)