search

SatcherInstitute / prototype

MIT License
4 stars 4 forks source link

Terraform #24

Closed slagathorr closed 3 years ago

slagathorr commented 3 years ago

Tweaked a couple things based off of Jennie's comments on the last PR#22, but I didn't know how (or if it's even possible) to merge that into an open PR, so I just closed it, pushed the changes, and opened a new PR. If there's a better way to do that, I'd love to know!

slagathorr commented 3 years ago

Are the test datafiles used in this PR? They seem out of place. Maybe move to a different PR?

@mayaspivak For this build they're used to load the BQ tables and the SQL query won't work without them. It's intended to be a temporary placeholder so there's a structure to build off of, and will be deleted and redirected to the dynamically generated tables once the pipelines are in place.

slagathorr commented 3 years ago

@mayaspivak Okay I'm still learning how to github, wasn't sure how to comment directly on your change request, so hit the "re-request review" button but not sure if that's the right workflow.

jenniebrown commented 3 years ago

Tweaked a couple things based off of Jennie's comments on the last PR#22, but I didn't know how (or if it's even possible) to merge that into an open PR, so I just closed it, pushed the changes, and opened a new PR. If there's a better way to do that, I'd love to know!

If you commit and push your changes, they should be automatically added to the PR so you can just hit 're-request review' (found the answer from this article: https://homes.cs.washington.edu/~mernst/advice/github-pull-request.html#respond-to-reviews)

slagathorr commented 3 years ago

Tweaked a couple things based off of Jennie's comments on the last PR#22, but I didn't know how (or if it's even possible) to merge that into an open PR, so I just closed it, pushed the changes, and opened a new PR. If there's a better way to do that, I'd love to know!

If you commit and push your changes, they should be automatically added to the PR so you can just hit 're-request review' (found the answer from this article: https://homes.cs.washington.edu/~mernst/advice/github-pull-request.html#respond-to-reviews)

Ah okay, that's helpful to know. And also makes WAY more sense. Also I've been using PRs incorrectly (when to use them and how to logically group changes and such) so good to know to make them more readable going forward. Thanks!