SatelCreative / spylib

A library to facilitate interfacing with Shopify's API
https://satelcreative.github.io/spylib
MIT License
3 stars 2 forks source link

🐛 webhook graphql not found in Azure function app use case #149

Closed lishanl closed 2 years ago

lishanl commented 2 years ago

Please open an issue for this. This is separate from this PR

I just tested this spylib (install it via this branch) in st-cim (running as an azure function) and it returned error about graphql file not found like @qw-in mentioned before.

Originally posted by @hillairet in https://github.com/SatelCreative/spylib/issues/143#issuecomment-1166052381

hillairet commented 2 years ago

The top answer of this stackoverflow would probably solve it but I don't think I want to experiment with this and risk to encounter issues in other special cases. Better to switch to strings indeed.

I'd keep these strings in a separate file so while you are at it, do you mind creating a folder such that:

webhook.py -> webhook/__init__.py
webhook.graphql -> webhook/graphql_queries.py
lishanl commented 2 years ago

The top answer of this stackoverflow would probably solve it but I don't think I want to experiment with this and risk to encounter issues in other special cases. Better to switch to strings indeed.

I'd keep these strings in a separate file so while you are at it, do you mind creating a folder such that:

webhook.py -> webhook/__init__.py
webhook.graphql -> webhook/graphql_queries.py

sure in a separate PR ?

hillairet commented 2 years ago

Well yeah a PR for this issue.