search

SatelCreative / spylib

A library to facilitate interfacing with Shopify's API
https://satelcreative.github.io/spylib
MIT License
3 stars 2 forks source link

Merge new hmac signature validation with oauth validation if possible #150

Closed hillairet closed 2 years ago

hillairet commented 2 years ago

While preparing a new validation function for hmac in PR #147, @qw-in noticed something (original post)

Noticed in oauth/validations.py it attempts to handle sorting query string so I didn't want to remove that code and potentially break that behaviour. (seems like a workaround for a bonnette bug). Thoughts on how to handle?

@lishanl Could you make a branch, remove the sorting and test it out on azure somehow to find out if it's needed or not? We don't need Bonnette anymore ...