SatelCreative / spylib

A library to facilitate interfacing with Shopify's API
https://satelcreative.github.io/spylib
MIT License
3 stars 2 forks source link

:sparkles: Change load to async #182

Closed ponty33 closed 1 year ago

ponty33 commented 1 year ago

Close #169

ponty33 commented 1 year ago

The example in the doc is already written as async... https://github.com/SatelCreative/spylib/blob/f191886c597b0a26f4911484b22a149865b26e49/docs/admin-api.md?plain=1#L19 Any suggestion on where else I should write the reminder?

hillairet commented 1 year ago

The example in the doc is already written as async...

https://github.com/SatelCreative/spylib/blob/f191886c597b0a26f4911484b22a149865b26e49/docs/admin-api.md?plain=1#L19

Any suggestion on where else I should write the reminder?

At this line you can something like: Note: up to version 0.8.x, the load was sync instead of async.

Some sort of breaking change warning would be nice such as :boom:

ponty33 commented 1 year ago

Prior to 0.8.1 should just be sync. I don't think you can override it with async