search

SatelCreative / spylib

A library to facilitate interfacing with Shopify's API
https://satelcreative.github.io/spylib
MIT License
3 stars 2 forks source link

Add gitmoji in PR title enforcement #92

Closed hillairet closed 2 years ago

hillairet commented 2 years ago

Let's start documenting our commits to main properly to make our changelog better as soon as possible. Please add the github action to enforce the gitmoji in PR titles.

rahulpatidar0191 commented 2 years ago

I came across this recently to generate changelog for a release https://github.com/marketplace/actions/generate-release-changelog

hillairet commented 2 years ago

Ok this automation would be nice so it's all in Github but we need it to create the release only on tags of the format XX.YY.ZZ and not XX.YY.ZZ-* such as 1.2.3-beta1. The idea is to see the changelog between the releases. I'm pretty sure having prereleases would mess this up. So could you skip/exit if there is - in the tag?

rahulpatidar0191 commented 2 years ago

We can do something like this to ignore tags with -


on:
  push:
    tags-ignore:
      - '*-*' # We don't want this to run on release
hillairet commented 2 years ago

@rahulpatidar0191 The repo has a good amount of activity right now. It'd be good to have this done. Even Lishan forgets the gitmojis! :wink: