feat(releaseData): add new hook for release data

Satellite-im / Core-PWA

Satellite Core is a decentralized p2p voice, video, and text chat application and is under heavy development. Check back soon for updates, or check out the latest version at https://core-dev.satellite.im

https://core-dev.satellite.im

Other

40 stars 16 forks source link

feat(releaseData): add new hook for release data #5383

Closed josephmcg closed 1 year ago

josephmcg commented 1 year ago

What this PR does 📖

create new compositions folder outside of /components. All compositions should be moved here eventually. we get lots of console warning about the current structure missing default exports
settings modal is fetching data every single mount. This will fetch one time on first render, then never again.
not yet implemented, waiting for other refactor to go through first

Which issue(s) this PR fixes 🔨

Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

github-actions[bot] commented 1 year ago

Download the .APK for this pull request:

debug-apk.zip

molimauro commented 1 year ago

There is also the built-in https://nuxtjs.org/docs/features/data-fetching.

Not against merging this though

josephmcg commented 1 year ago

oh cool, are there any benefits to using nuxt to fetch data?

molimauro commented 1 year ago

oh it provides you all the fetching utilities, options, as well as the various pending/error states, the automatic caching on page revisits, browser refresh etc. Maybe we can even use this directly: https://v3.nuxtjs.org/getting-started/data-fetching#usefetch

josephmcg commented 1 year ago

im ok merging for now, down to take another look later