Satellite-im / Core-PWA

Satellite Core is a decentralized p2p voice, video, and text chat application and is under heavy development. Check back soon for updates, or check out the latest version at https://core-dev.satellite.im
https://core-dev.satellite.im
Other
40 stars 16 forks source link

fix(chat): banner "num new messages" fixed #5415

Closed molimauro closed 1 year ago

molimauro commented 1 year ago

What this PR does 📖

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

unreadMarkerMessageId is the real last message, even if this is not in the view, from this we derive the num of unreads and the "since" currentMarkerMessageId indicates the latest unread message in the view

Additional comments 🎤

github-actions[bot] commented 1 year ago

Download the .APK for this pull request:

WanderingHogan commented 1 year ago

I think this fixes some issues but there might be one unresolved issue that can go in another ticket

https://user-images.githubusercontent.com/2993032/198585521-36dc9667-6a70-4f45-a66e-ae40de50584a.mov

phillsatellite commented 1 year ago

Besides what @WanderingHogan found above and a small other thing I was able to replicate on dev as well PR was good 🔥

molimauro commented 1 year ago

@WanderingHogan sorry, did you click "reply"?

phillsatellite commented 1 year ago

@molimauro we can obv wait for Hogan to verify but I don't think he did, I tested replies and was all good, replicated bug on my side just by clicking the New Message banner