search

Satellite-im / Core-PWA

Satellite Core is a decentralized p2p voice, video, and text chat application and is under heavy development. Check back soon for updates, or check out the latest version at https://core-dev.satellite.im
https://core-dev.satellite.im
Other
40 stars 16 forks source link

chore(chat): set read on conversation scroll bottom #5467

Closed molimauro closed 1 year ago

molimauro commented 1 year ago

What this PR does 📖

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

github-actions[bot] commented 1 year ago

Download the .APK for this pull request:

josephmcg commented 1 year ago

I think Jason initially designed it to only mark as read if the user scrolls to the new message indicator. something to consider, this implementation could mark all messages as read even if the user hasn't seen unread messages offscreen above

molimauro commented 1 year ago

Oh yeah i know, this is just the first piece sorry i should have mentioned. The idea is to bring the user with the scroll to the first unread message when entering the chat. As a consequence this will be natural what do you think? :)

molimauro commented 1 year ago

@josephmcg (can you also review this please)