Satellite-im / UplinkWeb

Frontend for Uplink
https://uplink.satellite.im
MIT License
6 stars 2 forks source link

fix(CallPopUp): Enable call pop up when user is out of active call chat #855

Closed lgmarchi closed 1 day ago

lgmarchi commented 1 week ago

What this PR does 📖

This pull request includes significant updates to the VideoPreview component in the calling module. The changes involve enhancing the video preview functionality, improving the user interface, and fixing the visibility toggle for the call screen.

Enhancements to VideoPreview functionality:

User interface improvements:

Visibility toggle fix:

Re-enabling the VideoPreview component:

Special notes for QAs 🧪

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

github-actions[bot] commented 1 week ago

Download the app installers for this pull request:

lgmarchi commented 1 week ago

@stavares843 and @phillsatellite I think it has a problem yet, when we test with user that didn't do the call.

lgmarchi commented 1 week ago
github-actions[bot] commented 4 days ago

Automated tests execution is complete! You can find the Playwright test report here and the Allure Test Report here

lgmarchi commented 3 days ago

so i tested with @phillsatellite and both on group and also on 1:1 and i had the following bug

Gravacao.do.ecra.2024-11-19.as.22.15.52.mov then both @phillsatellite and i had the following bug

290390209.mov also no image when i activate video but worked for @phillsatellite - works on dev

image

browser - chrome

Very interesting, I will do more tests and try to improve this code.

lgmarchi commented 1 day ago

so i tested with @phillsatellite and both on group and also on 1:1 and i had the following bug

Gravacao.do.ecra.2024-11-19.as.22.15.52.mov then both @phillsatellite and i had the following bug

290390209.mov also no image when i activate video but worked for @phillsatellite - works on dev

image

browser - chrome

I did a commit for it.