search

Satellite-im / Warp

Interface Driven Distributed Data Service
MIT License
15 stars 4 forks source link

chore: Remove unused function #550

Closed ashneverdawn closed 3 months ago

ashneverdawn commented 3 months ago

What this PR does 📖

Uses the const MAX_STATUS_LENGTH instead of 512. It was already being used everywhere else in warp-ipfs, but not in this case. Also, 512 is value of MAX_STATUS_LENGTH

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

dariusc93 commented 3 months ago

Can you correct the errors before merging?

EDIT: Looks like its a function that isnt used. Might be best to remove that instead?

ashneverdawn commented 3 months ago

Can you correct the errors before merging?

EDIT: Looks like its a function that isnt used. Might be best to remove that instead?

Somehow I left the constant out from the use statement, my mistake. But yeah, if it isn't used by anything in Warp or Uplink, then makes sense to remove it.

ashneverdawn commented 3 months ago

Can you correct the errors before merging?

EDIT: Looks like its a function that isnt used. Might be best to remove that instead?

Done.