search

Satellite-im / Warp

Interface Driven Distributed Data Service
MIT License
14 stars 3 forks source link

feat(raygun): Add size to download stream #555

Closed Flemmli97 closed 4 days ago

Flemmli97 commented 1 week ago

What this PR does 📖

Appends the file size to download streams in raygun

Flemmli97 commented 6 days ago

Im not to sure on if this should be needed since you could get the size of the file from scanning the attachments from the Message itself.

i guess thats also true but since the size is already fetched but not sent i would say to just also sent it with the data instead of needing to fetch again

dariusc93 commented 4 days ago

i guess thats also true but since the size is already fetched but not sent i would say to just also sent it with the data instead of needing to fetch again

The thing is that you would have to access the attachments in the message anyway, in which case would include File::size that represents the size of the attached file so adding it to the function may actually be redundant.

Flemmli97 commented 4 days ago

actually you are right. the ui already has information about the size. im closing this