search

SatelliteQE / airgun

AirGun is a Python library that is built over Widgetastic and navmazing to make Satellite 6 UI testing easier.
GNU General Public License v3.0
20 stars 66 forks source link

[6.15.z] ignore all hidden columns in SatTable widget #1468

Closed Satellite-QE closed 1 month ago

Satellite-QE commented 2 months ago

Cherrypick of PR: https://github.com/SatelliteQE/airgun/pull/1465

Problem Statement

The Hosts table HTML contains multiple duplicate columns that are hidden, like Name, Model, Operating system, etc. On the eye, the rendered result looks and behaves correctly, however these hidden columns are causing the widget airgun.widgets.SatTable to behave not fully correctly.

This flaw started to fully manifest by merging PR https://github.com/SatelliteQE/airgun/pull/1453 where the SatTable widget interacted with the hidden columns instead of the visible ones (and sometimes vice versa).

Solution

The SatTable widget is modified to ignore all hidden headers and columns in the table.

Satellite-QE commented 2 months ago

trigger: test-robottelo pytest: tests/foreman/ui/test_host.py::test_positive_read_from_details_page tests/foreman/ui/test_errata.py::test_positive_apply_for_all_hosts tests/foreman/ui/test_rhcloud_insights.py::test_insights_registration_with_capsule

Satellite-QE commented 2 months ago

PRT Result

Build Number: 321
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py::test_positive_read_from_details_page tests/foreman/ui/test_errata.py::test_positive_apply_for_all_hosts tests/foreman/ui/test_rhcloud_insights.py::test_insights_registration_with_capsule --external-logging
Test Result : ================== 10 warnings, 5 errors in 268.86s (0:04:28) ==================
Satellite-QE commented 2 months ago

PRT Result

Build Number: 322
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py::test_positive_read_from_details_page tests/foreman/ui/test_errata.py::test_positive_apply_for_all_hosts tests/foreman/ui/test_rhcloud_insights.py::test_insights_registration_with_capsule --external-logging
Test Result : =========== 1 failed, 4 passed, 1058 warnings in 4496.78s (1:14:56) ============
Satellite-QE commented 1 month ago

PRT Result

Build Number: 323
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_host.py::test_positive_read_from_details_page tests/foreman/ui/test_errata.py::test_positive_apply_for_all_hosts tests/foreman/ui/test_rhcloud_insights.py::test_insights_registration_with_capsule --external-logging
Test Result : ============ 1 failed, 4 passed, 835 warnings in 3620.80s (1:00:20) ============
pnovotny commented 1 month ago

Marking as PRT-Passed. After investigating the failure in the PRT run, test test_positive_apply_for_all_hosts does not fail because of navigation error to the host details page. It goes to the details page, but fails to find the Content tab there. The fix for this issue is outside of this PR scope.