search

SatelliteQE / puppet-robottelo_slave

GNU General Public License v3.0
0 stars 2 forks source link

Initial commit to add base level slave configuration #1

Closed ehelms closed 8 years ago

ehelms commented 8 years ago

There is a lot here initially as I wanted to make sure this was a full fledged puppet module with tests included. Due to the nature of using the foreman-infra puppet modules (specifically the slave module) somethings required some customization. The biggest two being a script to encapsulate and simplify applying the puppet module (and ensuring all dependencies are properly configured for the apply to work) as well as how the fixtures are generated when testing as this is different than the normal fixture setup for puppet module testing.

ehelms commented 8 years ago

Could someone with write access to this repository please turn on travis-ci for it?

ehelms commented 8 years ago

Closed / reopened to kick off Travis

ehelms commented 8 years ago

Tests are passing and this is ready for review. Things to check:

1) The parts that are applicable to properly configuring a slave for the required QE environment 2) The overall puppet module structure (@stbenjam would you be willing to assist?)

stbenjam commented 8 years ago

Given the context the puppet looks good so :smile_cat: and/or ACK from me

elyezer commented 8 years ago

ACK