SatelliteQE / robottelo

Robottelo is a test suite that exercises The Foreman.
GNU General Public License v3.0
61 stars 114 forks source link

Remove the MultiCV hack since it's become available #16893

Closed vsedmik closed 2 days ago

vsedmik commented 1 week ago

Problem Statement

MultiCV has become available in 6.17 via setting, no hacks are needed anymore.

Solution

Just remove the helper from mixins and fixture.

PRT test Cases example

trigger: test-robottelo pytest: tests/foreman/cli/test_host.py -k _multicv

vsedmik commented 1 week ago

trigger: test-robottelo pytest: tests/foreman/cli/test_host.py -k multi_cv

Satellite-QE commented 1 week ago

PRT Result

Build Number: 9326
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k multi_cv --external-logging
Test Result : ==== 2 passed, 88 deselected, 322 warnings, 6 errors in 1613.89s (0:26:53) =====
jeremylenz commented 1 week ago

PRT will fail until foreman_theme_satellite is released and in Stream.

chris1984 commented 3 days ago

trigger: test-robottelo pytest: tests/foreman/cli/test_host.py -k multi_cv

Satellite-QE commented 3 days ago

PRT Result

Build Number: 9428
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k multi_cv --external-logging
Test Result : ==== 2 failed, 6 passed, 88 deselected, 454 warnings in 1865.23s (0:31:05) =====
vsedmik commented 3 days ago

Those 2 failures are one parametrized negative test case

test_negative_multi_cv_registration[rhel8-ipv4]
test_negative_multi_cv_registration[rhel9-ipv4]

failing here with Failed: DID NOT RAISE exception, which is expected since the setting has been exposed in 6.17

    # Verify that allow_multiple_content_views setting is not exposed
    with pytest.raises(CLIReturnCodeError):
        target_sat.cli.Settings.info({'name': 'allow_multiple_content_views'})

We should remove the assertion.

vsedmik commented 3 days ago

trigger: test-robottelo pytest: tests/foreman/cli/test_host.py -k multi_cv

Satellite-QE commented 3 days ago

PRT Result

Build Number: 9429
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k multi_cv --external-logging
Test Result : ========= 8 passed, 88 deselected, 467 warnings in 1933.36s (0:32:13) ==========