Make Upgrade Scenaios fully independent of Environement Variables

SatelliteQE / robottelo

Robottelo is a test suite that exercises The Foreman.

GNU General Public License v3.0

61 stars 112 forks source link

Make Upgrade Scenaios fully independent of Environement Variables #7030

Closed jyejare closed 2 years ago

jyejare commented 5 years ago

Recently, Some initiatives and efforts have been taken to make upgrade scenarios fully independent of environment Variables such as #6908.

But I still see there is a dependency on environment variables, in case of:-

[ ] Helpers for upgrade scenarios are being used from the satellite6-upgrade repo, where those helpers need values from environment variables. Solution - Move all upgrade scenario helpers to robottelo utils and replace environment vars with robottelo settings.

jyejare commented 5 years ago

More thoughts folks ?

omkarkhatavkar commented 5 years ago

@jyejare I like the plan, we should move all dynamic variables getting instead evaluated from satellite-upgrade. This will give good control removing and adding new variables. One more suggestion from my side, we should keep a separate file for upgrade-related functions in robottelo-utils. It is good to have segregation.

jyejare commented 5 years ago

Yes @omkarkhatavkar , +1 for having a separate helper package and module for upgrade specific.

vijay8451 commented 5 years ago

+1 @jyejare to remove env vars dependency, and keep all in robottelo as that would help us to easy /centralized manage them.

jyejare commented 5 years ago

Thanks guys , Final thoughts from @san7ket @ntkathole ??

ntkathole commented 5 years ago

@jyejare +1

ntkathole commented 5 years ago

@jyejare where are we on this?

jyejare commented 5 years ago

@ntkathole, Nowhere :) , We need to start on this!

mshriver commented 2 years ago

With the introduction of dynaconf, settings and environment variable use and standards have changed. Closing this, as both robottelo and satellite6-upgrade repositories are now using dynaconf.