search

SatelliteQE / robottelo

Robottelo is a test suite that exercises The Foreman.
GNU General Public License v3.0
61 stars 114 forks source link

fix proxy cleanup in realm test #8447

Open pondrejk opened 3 years ago

pondrejk commented 3 years ago

kudos to @rplevka for investigation this fixture: https://github.com/SatelliteQE/robottelo/blob/master/tests/foreman/cli/test_realm.py#L34 creates a foreman smart proxy (fake one, it's just an internal proxy loopback on a new port). since there is no cleanup, it stays created even thought the tunnel is destroyed, thus the smart proxy on that port number is no longer reachable.

this creates issues with other tests - for example one that use "deploy PXE default template" feature, which goes through all capsules. it now fails on it.

I think these proxy records are greedy and are being assigned to every new organization.

rplevka commented 3 years ago

anyway, as @mshriver has noted in the chat, the test uses a fixture that registers a finalizer. This finalizer should delete the proxy.

I believe the whole issue boils down to this method failing to do so. I'll try to dig out the production.log to see if ther was a DELETE request and how it went.