SatelliteShorelines / CoastSeg

An interactive toolbox for downloading satellite imagery, applying image segmentation models, mapping shoreline positions and more. The mapping extension for CoastSat and Zoo.
https://satelliteshorelines.github.io/CoastSeg/
GNU General Public License v3.0
45 stars 9 forks source link

CoastSeg is not compatible with pyTMD 2.1.7 #279

Closed 2320sharon closed 2 hours ago

2320sharon commented 5 hours ago

When running tide correction with the latest pyTMD version the error below occurs due to changes in the pyTMD api

Traceback (most recent call last):
  File "c:\development\doodleverse\coastseg\CoastSeg\4_tide_correction.py", line 61, in <module>
    coastsegmap.compute_tidal_corrections(roi_ids, beach_slope, reference_elevation)
  File "C:\development\doodleverse\coastseg\CoastSeg\src\coastseg\coastseg_map.py", line 543, in compute_tidal_corrections  
    raise Exception(f"""Tide Model Error:\n {e}""")
Exception: Tide Model Error:
 cannot access local variable 'ph' where it is not associated with a value
2320sharon commented 4 hours ago

This is due to the fact that in the most recent up to pyTMD is pyTMD.io.model format property is no longer called FES but netcdf-FES

2320sharon commented 2 hours ago

This has been fixed in version 1.2.16