search

SatelliteShorelines / SDS_Benchmark

Benchmarking of satellite-derived shoreline mapping techniques
GNU General Public License v3.0
16 stars 10 forks source link

Update tides for TORREYPINES and TRUCVERT #11

Open yongjingmao opened 8 months ago

yongjingmao commented 8 months ago

Update the tide data with correct coordinate inputs.

kvos commented 8 months ago

thanks @yongjingmao, it looks like a major issue as the new tide time-series are completely different. I will rerun the analysis for these two sites, could you also commit the uploaded tides script? thanks

yongjingmao commented 8 months ago

Add script for tide computation

kvos commented 6 months ago

hi @yongjingmao , sorry I only had time to look at this now. Thanks for the updated tides, I was trying to run the notebook again but the new tides are only until 2013, could you please upload the files with the tides until 1st Jan 2025? Thanks

yongjingmao commented 6 months ago

Hi Kilian,

The file is complete on my side. Github might cut it off during pulling. Below is the link to the correct file. Please let me know if there is any issue.

Cheers,

Mao TRUCVERTtides.csv <https://drive.google.com/file/d/1nXrX-I4X-LWDQYpQBbFbnaoiPsA1ZyV/view?usp=drive_web>

On Fri, Jan 5, 2024 at 9:46 PM Kilian Vos @.***> wrote:

hi @yongjingmao https://github.com/yongjingmao , sorry I only had time to look at this now. Thanks for the updated tides, I was trying to run the notebook again but the new tides are only until 2013, could you please upload the files with the tides until 1st Jan 2025? Thanks

— Reply to this email directly, view it on GitHub https://github.com/SatelliteShorelines/SDS_Benchmark/pull/11#issuecomment-1878471138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHY3MMPKOPNS2IU5LRNPYTLYM7K2DAVCNFSM6AAAAAA7D5KWGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZYGQ3TCMJTHA . You are receiving this because you were mentioned.Message ID: @.***>

kvos commented 6 months ago

thanks, can you please also send me the link tp the updated TORREYPINES tides?

yongjingmao commented 6 months ago

Hi Kilian,

Please find the attached. TORREYPINES_tides.csv https://drive.google.com/file/d/1gefqB55BNE_eNORberiTneKiw4Fo7LNh/view?usp=drive_web

On Sat, Jan 6, 2024 at 8:32 AM Kilian Vos @.***> wrote:

thanks, can you please also send me the link tp the updated TORREYPINES tides?

— Reply to this email directly, view it on GitHub https://github.com/SatelliteShorelines/SDS_Benchmark/pull/11#issuecomment-1879280804, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHY3MMJISASCCFTC4FACOGDYNBWQJAVCNFSM6AAAAAA7D5KWGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGI4DAOBQGQ . You are receiving this because you were mentioned.Message ID: @.***>

kvos commented 6 months ago

thanks @yongjingmao , it was a good catch. I re-ran the analysis with the new tides and for TORREYPINEs and TRUCVERT for the 3 algorithms that are tidally-corrected (CoastSat, SHOREX and CASSIE) it does make a difference. See plots below:

Figure in the paper: 3_R2_selected

Revised figure with new tides: 3_R2_selected

While it doesn't change much at Truc Vert, the SDS time-series are much improved at Torrey Pines. I will contact the journal to see if this can be updated somehow, I don't think it changes the conclusions of the paper in any way but it would be better to have the most accurate figure possible.