SatelliteShorelines / coastsat_package

prototype pypi package for coastsat
https://pypi.org/project/coastsat-package/
GNU General Public License v3.0
6 stars 1 forks source link

Feature Request: Update coastsat_package and coastseg to be less sensitive to tiff name changes #10

Open 2320sharon opened 1 year ago

2320sharon commented 1 year ago

This bug was reported by a user who was editing the reference shoreline after loading from a session where the data had been downloaded in a previous session. When the user attempted to extract shorelines they got a no roi_settings found error despite the fact the log file for show that when the user loaded the session load_config_json shows that the roi settings were read from the config.json file.

Relevant Files

roi_setting_bug.zip

2320sharon commented 1 year ago

We found the cause of the issue

When it downloads files it puts the session name in it and when you download any files a new session name is created using the current time you downloaded data. So all your files from the other session have the wrong name which means they all got filtered out because the session name didn't match.

2320sharon commented 1 year ago

This issue would need to be fixed in both coastsat_package and coastseg. Basically instead of reading the exact filename it should query the correct file based on the date and satellite. To avoid this kind of issue in the future coastsat_package should be updated to no longer save the sitename as part of the filename. This would make combining multiple download MUCH easier