search

SathyaBhat / spotify-dl

Downloads songs from your Spotify Playlist
http://sathyasays.com/2015/12/29/spotify-dl-download-your-spotify-my-music-songs-as-mp3/
MIT License
1.74k stars 214 forks source link

Adding Other Metadata #143

Closed gonzk closed 3 years ago

gonzk commented 3 years ago

(This is my first time ever posting an issue, so hopefully this is the right way to do it)

I would like to do a PR (first time as well), so that when the songs download, it'll also contain the track no, album, year, and cover. I would be using the Spotiy API to get these pieces of information.

SathyaBhat commented 3 years ago

Hi @gonzk, that would be great., you can go for it. At the moment, only the track name, artist and album are fetched from the API but you should be able to extend it

https://github.com/SathyaBhat/spotify-dl/blob/master/spotify_dl/spotify.py#L19 https://developer.spotify.com/documentation/web-api/reference/#category-playlists

For the cover there is an open PR #76 that you can combine with in your PR

gonzk commented 3 years ago

Thank you! Okay, I have other ideas of how to get the other metadata.

gonzk commented 3 years ago

For the cover, do I have to combine with the other open PR? I just figured out how to add the cover album using a different way from the PR #76

SathyaBhat commented 3 years ago

Hi @gonzk, you can ignore the other PR, I will close it as its far too behind the main branch

gonzk commented 3 years ago

Is there anything else I need to do to my PR? I think it's finished and could be merged, if you think the issues have been addressed.

SathyaBhat commented 3 years ago

Hi @gonzk, nothing more for you to do. I'll merge in the changes and cut a release within the next couple of days. Till then I will keep the PRs open. Thanks again!

SathyaBhat commented 3 years ago

Thanks again for your contributions, @gonzk. I've cut a release v7.5 which features your enhancements

https://pypi.org/project/spotify-dl/#history