Various search improvements

[Maritsu]

Closes #373, might close #374.

• Uses YT Music for searching songs via ytmusicapi lib (note: the search filters by songs only!)
• Removes "Lyrics" keyword from search query (avoids e.g. more popular songs with lyric videos or fan-made lyrics)
• Makes use of Levenshtein edit distance (implemented in Levenshtein package) to get closest matching search result instead of the top one

Example of different result: Toby Fox - Death by Glamour

• upstream downloads this fan-made lyric video
• downstream downloads the original track

[sentry-io[bot]]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: spotify_dl/youtube.py

Function	Unhandled Issue
find_and_download_songs	IndexError: list index out of range spotify_dl.yo... Event Count: 1

---

_{Did you find this useful? React with a 👍 or 👎}

[Maritsu]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: spotify_dl/youtube.py Function Unhandled Issue find_and_download_songs IndexError: list index out of range spotify_dl.yo... Event Count: 1

Did you find this useful? React with a 👍 or 👎

I'm unable to open the linked issue, is this error my fault or has it been here previously?

[SathyaBhat]

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues: 📄 File: spotify_dl/youtube.py Function Unhandled Issue find_and_download_songs IndexError: list index out of range spotify_dl.yo... Event Count: 1 Did you find this useful? React with a 👍 or 👎

I'm unable to open the linked issue, is this error my fault or has it been here previously?

it's in my sentry account that is private

[Maritsu]

I see. I'm not sure I understand @sentry-io's message though - is the IndexError something I caused, or has it been in find_and_download_songs() before?

[Maritsu]

On another note, this PR doesn't seem to make that much of a difference in search result quality - I'll mark as draft and extend the functionality to select the closest match from the top few search results.

[Maritsu]

Should work somewhat better now. Unmarked as draft, ready for review!

[SathyaBhat]

doesn't look like ytmusicapi supports Python 3.7.. need to remove support for it in the pipeline and add new versions

[Maritsu]

yup, just noticed it requires Python 3.8 or newer. should I update the pipeline then?

[SathyaBhat]

Yeah, if you don't mind, go for it. Can also add Python 3.9, 10, 11 -- Sathya https://about.sathyabh.at/ Author, Practical Docker with Python https://www.apress.com/gp/book/9781484237830 & The CDK Book https://www.thecdkbook.com/ | AWS Community Hero https://aws.amazon.com/developer/community/heroes/sathyajith-bhat/

On Tue, 4 Jun 2024 at 02:26, jan Mikowa @.***> wrote:

yup, just noticed it requires Python 3.8 or newer. should I update the pipeline then?

— Reply to this email directly, view it on GitHub https://github.com/SathyaBhat/spotify-dl/pull/375#issuecomment-2145640241, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGGUCPOU634MV6IOHLIWLZFSKKDAVCNFSM6AAAAABIJCPB4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGY2DAMRUGE . You are receiving this because you commented.Message ID: @.***>

[Maritsu]

sure, i'll try as soon as i can

[Maritsu]

update done! i changed the version range to 3.8-3.12

[Maritsu]

didn't notice that, thank you for correcting!

[tposejank]

Another comment I'd like to leave here is some artists do like to publish their own Official Audio as a video and sometimes their YouTube release won't show up first in the search results, but that issue could be small and not matter a lot