search

Satoshi-Engineering / tip-cards

Lightning Tip Cards are a tip (or gift) card system, where you can fund tip cards via the lightning network and the gifted person can redeem the funded cards. The gifted person gets a short introduction to bitcoin and a lightning app recommendation to start their journey into the bitcoin rabbit hole.
MIT License
20 stars 10 forks source link

I will send a request with a lot of patches soon. Can you preview them beforehand? #10

Open Perlover opened 11 months ago

Perlover commented 11 months ago

Hello,

Thank you for the wonderful service!

I launched it on my domain. But I am not satisfied with some things and I decided to improve your server. I'm finishing the patches now. After that, I will create a pull request to merge with your branch. But to make this process smoother, can I ask you to look at my future patches?

At the moment, I have to finish translating the Russian language into a new one, since the old translation has many "white spots".

My current branch with patches:

https://github.com/Perlover/tip-cards

1) Added support for plural forms for different languages (for the future - now it only works in Czech and Russian) 2) Czech translation has been added 3) The previous Russian translation has been deleted so far and a new one has been placed in its place, based on the latest English translation file. A new translation will be made soon. 4) In some places, the messages have been changed to a plural form 5) Fix bug: Removed extra nextTick() in i18n plugin: frontend/src/modules/initI18n.ts 6) In some places, the formula 100 * 1000 * 1000 has been replaced with a more understandable and concise constant 1E8 7) Fix bug: the cards.settings.defaults.invoiceText message was not translated because it was in compile vue-3 section (setup script) and there was always default 'en' localized text. It was replaced to the computed prop from the currentLocale prop. 8) fixed small misprint in english text (en.json)

Soon I want to do the following:

Different languages, this is usually a specific country/territory. Your general section with links on how to spend bitcoin or where to buy it is not applicable in most cases.

For example, in the Czech Republic, it is easier to buy bitcoin at an ATM or at a popular local exchanger than at an exchange Kraken. And it is easier to spend bitcoin in the Czech Republic in other ways.

In Russia, for example, where a country is under sanctions due to a treacherous attack on another country, it is not realistic to buy bitcoin on the stock exchange (exchanges do not work with Russians). And it is also difficult to spend bitcoins there in the ways that you have indicated. But there are still several services that can be used by Russians. I want to redo this mechanism so that a general list of places of use is shown if no such list is defined for the local territory/language. If such a list is defined for the territory, we show it exactly.

daskleinesys commented 11 months ago

To be able to comment your changes I created a pull request: https://github.com/Satoshi-Engineering/tip-cards/pull/11

Perlover commented 10 months ago

To be able to comment your changes I created a pull request: #11

Thank you! I want to refine the branch a little more and then I will ask you to check it and merge it if you agree. Anyway, everything works fine for me on LNinv.com (from my branch with patches)