Lightning Tip Cards are a tip (or gift) card system, where you can fund tip cards via the lightning network and the gifted person can redeem the funded cards. The gifted person gets a short introduction to bitcoin and a lightning app recommendation to start their journey into the bitcoin rabbit hole.
MIT License
21
stars
10
forks
source link
Simplify LTR support for printing + small fixes for Hebrew translation #4
I saw that you tried to support right-to-left by reversing the order of the UI elements inside the cards (so the QR code will appear on the right and the text on the left).
I suggest a simpler approach - whenever the UX is complicated (i.e. things in "absolute" position), just stick with ltr direction, and only in the text elements set the direction to rtl (so their alignment will be to the right).
From my experience, browsers can behave really weird with complicated UI that is supposed to be rtl, and printing such web-pages or converting them to PDF can become a nightmare. Even if it works on Chrome, it might not work on Firefox/Safari, and vice-versa. The standardization of this issue is really bad.
The second commit is just some Hebrew fixes (There are two similar words for "loaded" and I want to use the same one everywhere).
I saw that you tried to support right-to-left by reversing the order of the UI elements inside the cards (so the QR code will appear on the right and the text on the left). I suggest a simpler approach - whenever the UX is complicated (i.e. things in "absolute" position), just stick with ltr direction, and only in the text elements set the direction to rtl (so their alignment will be to the right).
From my experience, browsers can behave really weird with complicated UI that is supposed to be rtl, and printing such web-pages or converting them to PDF can become a nightmare. Even if it works on Chrome, it might not work on Firefox/Safari, and vice-versa. The standardization of this issue is really bad.
The second commit is just some Hebrew fixes (There are two similar words for "loaded" and I want to use the same one everywhere).