SatoshiPortal / boltz-rust

Boltz client rust crate
https://docs.boltz.exchange
30 stars 16 forks source link

Strict typing the internal structs #23

Closed rajarshimaitra closed 4 months ago

rajarshimaitra commented 4 months ago

This PR uses strict typing for all the internal SwapScript and SwapTx structures.

This also removes two redundant dependency, rand and hex. These are already available from the bitcoin library.

i5hi commented 4 months ago

test_bitcoin_rsi works fine.

test_liquid_rsi is failing with this error:

thread 'test_liquid_rsi' panicked at tests/liquid.rs:131:10:
called `Result::unwrap()` on an `Err` value: Key(Base58(InvalidLength(3)))
i5hi commented 4 months ago

btw, you can ignore the failing electrum test. its a server side issue that we are patching right now.

i5hi commented 4 months ago

Looks good!

Thanks!