Closed ok300 closed 3 months ago
When calculating the Boltz service fees:
ceil
round
This is the case for both submarine and reverse submarine swaps.
This can be checked by manually entering values in https://boltz.exchange and observing the calculated Boltz fee:
Similar tests can be done with the reverse direction (normal submarine swaps).
Therefore, this PR:
Hey @ok300 Thanks for the PR! Logic and code looks good.
It fails the linting tests. I'll take care of it for now. For successive PRs make sure you run rust fmt ;)
When calculating the Boltz service fees:
ceil
instead ofround
, which rounds up or down)This is the case for both submarine and reverse submarine swaps.
This can be checked by manually entering values in https://boltz.exchange and observing the calculated Boltz fee:
ceil
round
would have resulted in 250,ceil
leads to the correct 251)Similar tests can be done with the reverse direction (normal submarine swaps).
Therefore, this PR:
ceil