SatoshiPortal / boltz-rust

Boltz client rust crate
https://docs.boltz.exchange
30 stars 16 forks source link

Use `native-tls` for better `close_notify` handling #41

Closed ok300 closed 2 months ago

ok300 commented 2 months ago

This PR enables the native-tls feature of ureq as described here: https://docs.rs/ureq/latest/ureq/#https--tls--ssl

This brings better handling of TLS close_notify alerts. Before this change, the default ureq setup caused some POST calls (like /swapstatus) to fail.

Fixes #39

i5hi commented 2 months ago

Hey @ok300 Thanks for the PR!

You will need to setup PGP signing for your commits. Didn't catch it on your last few PR's.

You can check out the docs here: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Also the rust-fmt test is complaining :(

ok300 commented 2 months ago

Done, signed the commits and ran cargo fmt.

i5hi commented 2 months ago

Awesome!

There is a huge PR that I have to review first and get merged which came in before this. This PR will create a merge conflict with that one. I'll have to hold off on merging this. Once that is merged, we will get back to this.

For now, you can carry on using your fork in your project so you aren't blocked.

i5hi commented 2 months ago

Hey, the other PR has been merged. You can sync and commit your changes.

i5hi commented 2 months ago

you potentially saved me hours of debugging with this PR!

we just faced this issue on android in an upstream project that uses boltz-dart.

I've updated boltz.rs & boltzv2.rs to use native-tls for POST calls.

Thank you!

Please share a Liquid address so I can tip you :)

ok300 commented 2 months ago

Awesome, I'll rebase soon and update this PR!

Maybe you can use my LN address carlos@oak-node.net , much appreciated 🙏

ok300 commented 2 months ago

I see the relevant changes are already in trunk, so no need to rebase and use this PR anymore.

I'll just close it, to keep things simple.

i5hi commented 2 months ago

Pheonix says unable to connect to oak-node.net