search

SatoshiPortal / bullbitcoin-mobile

The Bull Bitcoin Mobile Wallet and Exchange App
MIT License
60 stars 23 forks source link

Txn Label - Auto override #166

Closed saiy2k closed 11 months ago

saiy2k commented 11 months ago

App version: v0.1.92

There are 2 wallets: Pikachu and Vegeta.

  1. Create a receive address in Vegeta. Let's call it VAddr1
  2. Send sats from Pikachu to VAddr1 and label the Txn 'TxPSend1'
  3. In Vegeta, set the txn label as 'TxVRcv1'

Wallets looks as below: Label 001 Label 002

  1. NowSend sats again from Pikachu to VAddr1 and label the Txn 'TxPSend2' Label 003

  2. In Vegeta, set the txn label as 'TxVRcv2' 5.1 Before labeling Label 004

5.2 Immediately after labeling Label 005

5.3 After a refresh Label 006

The label 'TxVRcv2' overrides the label 'TxVRcv1' of the first transaction.

i5hi commented 11 months ago

Current behaviour of labeling:

Tx will inherit the address label. (we should make it so that if tx label is set, do not inherit from the address)

If address label is not set, it will inherit tx label, other wise changes in tx label will not affect address label.

i5hi commented 11 months ago

Needs review. We have made some fixes to label inheritance.