search

SatoshiPortal / cyphernode

Modular Bitcoin full-node microservices API server architecture and utilities toolkit to build scalable, secure and featureful apps and services without trusted third parties
MIT License
365 stars 69 forks source link

Separate Bitcoin Core RPC and Protocol ports #130

Closed Kexkey closed 2 years ago

Kexkey commented 5 years ago

In setup, we ask if we want to expose Bitcoin ports (RPC and Protocol). That should be 2 different configs.

Do you want to expose RPC port? Do you want to expose Protocol port?

phillamy commented 2 years ago

Currently, the installer says:

_? Installer: Expose bitcoin full node outside of the docker network?

By default, Bitcoin node port (P2P port) will NOT be published outside of Docker. Do you want to expose it so that your node can be accessed from outside of the Docker network?_

Should become 2 separate questions :

1) ? Installer: Expose bitcoin full node P2P port outside of the docker network?

By default, Bitcoin node P2P port will NOT be published outside of Docker. Do you want to expose it so that your node can be accessed from outside of the Docker network?

2) ? Installer: Expose bitcoin full node RPC port outside of the docker network?

By default, Bitcoin node RPC port will NOT be published outside of Docker. Do you want to expose it so that your node can be accessed from outside of the Docker network?

@Kexkey : Is it what you meant ?

phillamy commented 2 years ago

After review with @Kexkey , RPC port will never be exposed outside of Docker network (done in feb 2020). So the actual question ==> Installer: Expose bitcoin full node outside of the docker network?

Will be changed to ==> Installer: Expose bitcoin full node P2P port outside of the docker network?

phillamy commented 2 years ago

PR: ? Installer: Expose bitcoin full node P2P port outside of the docker network?

By default, Bitcoin node port (P2P port) will NOT be published outside of Docker. Do you want to expose it so that your node can be accessed from outside of the Docker network?

image

Kexkey commented 2 years ago

https://github.com/SatoshiPortal/cyphernode/pull/236