Closed gabidi closed 4 years ago
Should we call it getspendingtxlist
instead, to make it clear the returned result doesn't include watched transactions that are not related to the spending wallet?
@gabidi I'd like gettxnslist
to be more clear it returns only transactions related to the spending wallet... (not the xpubs, the watching, wasabi, etc.) Do you have a suggestion? Something like getspendingtxlist
could make it ... @schulterklopfer what do you think?
@gabidi I'd like
gettxnslist
to be more clear it returns only transactions related to the spending wallet... (not the xpubs, the watching, wasabi, etc.) Do you have a suggestion? Something likegetspendingtxlist
could make it ... @schulterklopfer what do you think?
Sure we can rename it to getspendingtxlist
. We should collect the requirements now with a somewhat clean API and redesign it properly in v1.
But if you rename it, be sure to not remove the old endpoint and just mark it as obsolete or sth, in case someone (Bullbitcoin) is using it ;-)
This PR aim to add to new endpoints to cyphernode
/get_txns_by_watchlabel/<label>
Given a pub32 watch<label>
, this will return the Txns that have been observed (recorded in Cyphernode's DB) for addresses belonging to the pub32 pointed by the label, payload interface:get_unused_addresses_by_watchlabel/<label>/
Given a pub32 watch<label>
, this will return unused addresses, IE Pub32 derived addresses that have no observed transactions in Cyphernode's DB for the Pub32 pointed to by the supplied label.Bonus:
gettxnslist/<count>/<skip>
Adds support for RPC calllisttransactions
for spender wallets https://bitcoin-rpc.github.io/en/doc/0.17.99/rpc/wallet/listtransactions/--
Functionality has already been integrated into SDK and tests pass v0.0.8
TODO