search

SatoshiPortal / cyphernode

Modular Bitcoin full-node microservices API server architecture and utilities toolkit to build scalable, secure and featureful apps and services without trusted third parties
MIT License
363 stars 68 forks source link

change fee type to integer #162

Closed nk1tz closed 4 years ago

nk1tz commented 4 years ago

Noticed when importing into editor.swagger.io

Screen Shot 2020-02-06 at 5 17 37 PM

This should simply be an integer if it's referring to the sat/byte type of fee.

Kexkey commented 4 years ago

Thanks for the PR! However, fee is not an integer, it is a number with up to 8 decimals. It is the fee for the transaction (if available) in BTC, not the fee rate. Even if it was the feerate, sometimes it is expressed as floating point. This endpoint returns listtransactions RPC response of Bitcoin Core.

gabidi commented 4 years ago

Fixed in #180 https://github.com/SatoshiPortal/cyphernode/pull/180/commits/cc82516f0fb8654f54a104f44171e019af5c4463#diff-a3622bca69bfa1c660bb1cdbeb36ff01R2138