search

SatoshiPortal / cyphernode

Modular Bitcoin full-node microservices API server architecture and utilities toolkit to build scalable, secure and featureful apps and services without trusted third parties
MIT License
364 stars 68 forks source link

Add getmininginfo call #228

Open BHodl opened 3 years ago

BHodl commented 3 years ago

Let me know if I miss something. Not tested!

BHodl commented 3 years ago

The getmininginfo call tested and working. The getblockhashps call don't pass the gatekeeper. Maybe related to api.properties, wip.

BHodl commented 3 years ago

Fixed but.. Currently getblockhashps with optional blockheight not returning the right hashps. Let wait the node is fully synced to see... Maybe we shoudl add a send_to_stats_node function for that kind of call, not including wallet specifics.

Kexkey commented 3 years ago

Thanks and sorry for the delay, have been particularly busy lately.

Did you get a chance to make it work?

BHodl commented 3 years ago

Yeah! No problemo, we all want to see lnurl stuff in cyphernode, keep up the good work! The getmininginfo is working perfectly, but things need to be modified for the getblockhashps. I will probably change the call name for getnetworkhashps to be consistent with bitcoincore call, and modify the returned data. I wait my cyphernode to be fully sync to test that one. I will confirm when fully tested.

BHodl commented 3 years ago

Fully tested and working! It's my first PR so let me know if I miss something. I'm mostly setup for testing changes now, next time I will probably do my coding and testing before pushing the PR. One thing that can be improved is adding a send_to_stats_node function in sendtobitcoinnode.sh not including wallets specifics for stats call. But since it's affect all stats call, a separate PR would be better. Let me know what you think!

BHodl commented 2 years ago

Updated to solve v0.8.0 conflicts. Tested and working.

Kexkey commented 2 years ago

Rebase on dev, thanks!