search

SatoshiPortal / cyphernode

Modular Bitcoin full-node microservices API server architecture and utilities toolkit to build scalable, secure and featureful apps and services without trusted third parties
MIT License
362 stars 68 forks source link

Fix test container name #251

Closed BHodl closed 2 years ago

BHodl commented 2 years ago

Proposed fix for issue #250

Kexkey commented 2 years ago

So if you could just use the name: fix I described in the issue, that would be cleaner. I'm ok with not displaying verbose stuff from the tests though, good thing you removed them.

Are you willing to make a PR in the cypherapps repo for the other fix I described in the issue?

Thanks so much!!

BHodl commented 2 years ago

Yes I will fix it this way then, and fix cypherapps. And yes I use docker-compose. Thanks!

Kexkey commented 2 years ago

It looks like name is not allowed in Swarm mode:

(root) Additional property name is not allowed

You will have to add the <% if ( docker_mode !== 'swarm' ) { %> condition in the docker-compose.yaml template...

Kexkey commented 2 years ago

haha you're fast!

Kexkey commented 2 years ago

Awesome! This will be part of the next minor release, v0.8.1. You made me check some other stuff as well and found that there are problems with the tests (in proxy_docker/app/tests/) when using docker-compose... I fixed them.

Thanks again!

BHodl commented 2 years ago

Not so fast, I did't had time to test in my lab, just finished the test and get an error preventing cyphernode to start properly. ERROR: The Compose file '/home/user/Workspace/cyphernode/dist/docker-compose.yaml' is invalid because: 'name' does not match any of the regexes: '^x-'

BHodl commented 2 years ago

docker-compose version 1.29.2

BHodl commented 2 years ago

Adding -p cyphernode to docker-compose in start.sh script (line 69) is a better fix, at least it work for me.

BHodl commented 2 years ago

Check #253

Kexkey commented 2 years ago

Yeah I got that error on my Mac but then I upgraded docker-compose and the error went away. But your new PR is much better, good call!