search

SatoshiPortal / cyphernode

Modular Bitcoin full-node microservices API server architecture and utilities toolkit to build scalable, secure and featureful apps and services without trusted third parties
MIT License
362 stars 68 forks source link

Releases/v0.8.0 fix test monitor #253

Closed BHodl closed 2 years ago

BHodl commented 2 years ago

Better working fix for test monitor

Kexkey commented 2 years ago

I think we should add -p $APP_ID in start_apps()

What do you think?

Kexkey commented 2 years ago

Oh by default docker-compose will use the dir name as the project name, and APP_ID is the dir name, so it won't change anything. But I still think we should add it, if in the future APP_ID is not necessarily the dir name, it will already be set correctly.

Kexkey commented 2 years ago

You need to specify the project name in stop.sh also, because docker-compose will take "dist" by default and won't be able to stop "cyphernode"...

BHodl commented 2 years ago

Yep you're right for the stop script, it need the stack name. Added the -p $APP_ID to. Working as expected in my testing. Also check the PR # 17 on the cypherapp repo, tested and work as expected.

BHodl commented 2 years ago

... with docker-compose.

Kexkey commented 2 years ago

Awesome, thanks!