search

SatoshiPortal / cyphernode

Modular Bitcoin full-node microservices API server architecture and utilities toolkit to build scalable, secure and featureful apps and services without trusted third parties
MIT License
362 stars 68 forks source link

Rpc passwords special characters bug #270

Open i5hi opened 2 years ago

i5hi commented 2 years ago

Cyphernode setup.sh allows users to set an rpcpassword with whitespaces or quotes and these values will lead to bitcoin container not passing its tests.

Try setting passwords with whitespaces or quotes.

With whitespaces the bitcoin container starts and syncs blockdata but rpc will not work.

With quotes used in the password, the node does not start because the bitcoin.conf value for rpcpassword ends up replacing each quote replaced with " and errors due to invalid conf

i5hi commented 2 years ago

This regex can prevent using quotes of all kinds and slashes which might also be toublesome?

[^ " ' ` # % $ \/ \\ ]

As for spaces, a quick fix could just remove spaces + add it to the info in setup.

*Edit: Added more special characters to the regex based on this error which did not like the # character:

/.bitcoin/entrypoint.sh: line 15: /.bitcoin/createWallets.sh: Permission denied
Error: Error reading configuration file: parse error on line 26, using # in rpcpassword can be ambiguous and should be avoided