search

SatoshiPortal / lwk-dart

Dart/Flutter bindings for Blockstream's Liquid Wallet Kit
MIT License
8 stars 8 forks source link

Export common AssetIds #13

Open i5hi opened 5 months ago

i5hi commented 5 months ago

The library should export commonly used AssetIds:

Saleciani commented 5 months ago

Is it possible to include:

Depix -> 02f22f8d9c76ab41661a2729e4752e2c5d1a263012141b86ea98af5472df5189 Pegx Eur -> 18729918ab4bca843656f08d4dd877bed6641fbd596a0a963abbf199cfeb3cec

Saleciani commented 5 months ago

I want to understand what will be the type of behaviour you will want to add to lwk dart. Right now balances is a List<(string, int)>

Are you thinking in adding somekind of token parsing on lwk so that user just says balances.usdt

Or

Are you just planning in creating a getter where it will return to the user the string of the asset if and then we parse it to whatever asset it corresponds on our end?

Saleciani commented 5 months ago

Upon further investigation i see that for now on my end i can just get the first parameter of the List and parse the id on my end.

Will you deprecate this ability?

Ideally we would keep the the List<(string, int)> but then just add some getters for the common assets 🤔

i5hi commented 5 months ago

The benefit of having List<(String, int)> is that is allows the end user to manage whatever assets they like.

Adding getters for common assets is a good idea.

This could be a simple PR for you to give a try.

Saleciani commented 5 months ago

As soon as I have the basic behaviour in my app done I will start tackling these. 😀

i5hi commented 5 months ago

Currently AssetIds are in root.dart as consts.

Will be better to move them to a constants.dart file.