Satshabad
commented
11 years ago All inside 'song' dictionary:
album dictionary still has 'mbid' and '#text' keys artist dictionary still has 'url' and 'mbid' keys artist dictionary still has the old 'image' dictionary, along with the new proper 'images' dictionary
I left them in there on purpose. There is no reason to take them out. It's just more tests and more code and more dependency on them to be there in the first place. Just ignore them.
Also consider the 'recommendedAlbum' again - I know I'd use it, and it also gives me something to put for the detail text in the Queue with artists, which keeps the look consistent.
If you really think so, open separate issue.
Now is as good a time as any to add that if we'll ever use it.
I have several problems with this statement
Why is now a good as a time as any? Will there ever be a better time? You mean the need for having this "feature" will never be greater than it is now? Well that doesn't say very much about the feature since we don't really need it right now. I think there there will a certain optimal time to add this feature and we won't add it until then.
if we'll ever use it.
Feature creep is a very serious issue and it can bog us down, confused the user, dilute the functionality and purpose of the app, and depress me. Let's not add things to this app that we may never use.
...and to keep it consistent with our class structure and the standard set by queue items:
All inside 'song' dictionary:
None of this is critical at the moment, but I figured you'd wanna know, especially if we're about to go in and change anything anyways, might as well do this at the same time.
Also consider the 'recommendedAlbum' again - I know I'd use it, and it also gives me something to put for the detail text in the Queue with artists, which keeps the look consistent. Now is as good a time as any to add that if we'll ever use it.