Satshabad / Queue-api

An API server for the Queue app
0 stars 1 forks source link

Caching #9

Open Satshabad opened 11 years ago

Satshabad commented 11 years ago

After some research, I'm pushing this to after 0.6.0. If it's a real problem for us, we'll work it out. Otherwise it's opening a large can of worms I don't want to get into for now.

@fskhalsa

fskhalsa commented 11 years ago

Did you read that excerpt in the most recent doc I sent you? It sounds fairly simple - just send a header with each response to a queue get, and then implement the w3c protocol for checking incoming request headers. You just send back a 304 if the header in the request is the same as your current one.

​It sounds like its a standard we should be implementing anyways...

— Sent from Mailbox for iPhone

On Fri, May 24, 2013 at 2:18 PM, Satshabad notifications@github.com wrote:

After some research, I'm pushing this to after 0.6.0. If it's a real problem for us, we'll work it out. Otherwise it's opening a large can of worms I don't want to get into for now.

@fskhalsa

Reply to this email directly or view it on GitHub: https://github.com/Satshabad/Queue-API/issues/9

Satshabad commented 11 years ago

Did you read that excerpt in the most recent doc I sent you?

Yes.

It sounds fairly simple - just send a header with each response to a queue get, and then implement the w3c protocol for checking incoming request headers. You just send back a 304 if the header in the request is the same as your current one.

Oh is that all? feel free to submit a pull request then

It sounds like its a standard we should be implementing anyways...

you keep using that word, "standard". It's becoming meaningless to me. Just because something is Standard™ doesn't mean it's right for us to do it. Hell, there are plenty of terrible standards, look at some of these. You know what the only standard is? Use your brain. Sometimes that will mean following a predefined set of rules and sometimes not.

Like I said, it will take some work to get caching working, and right now if we can get by without it, that would be great. If it's a serious problem, then we can address it.

— Sent my iPhone 6 (yes, I have one)

fskhalsa commented 11 years ago

Oh, is standard a trademark now?

​That aside, sure, I take your point. It's a good one. We'll do as necessary.

As regards me changing the code - same as before - I'd have to study it all and get what it's doing first, and I've got a good deal to do just on the app as it is, so that probably doesn't make sense at this point. It would take too long. 

Just the same as it would probably take you an hour or two longer than me to fix something like that overlapping text issue. 

​At some point it probably makes sense for us to both understand each others code though, yes. 

"Sent my iPhone 6"?

All grammar aside, the next one is likely to be a 5S... 

— Sent from Mailbox for iPhone

On Fri, May 24, 2013 at 4:34 PM, Satshabad notifications@github.com wrote:

Did you read that excerpt in the most recent doc I sent you?

Yes. It sounds fairly simple - just send a header with each response to a queue get, and then implement the w3c protocol for checking incoming request headers. You just send back a 304 if the header in the request is the same as your current one.

Oh is that all? feel free to submit a pull request then

It sounds like its a standard we should be implementing anyways...

you keep using that word, "standard". It's becoming meaningless to me. Just becasue something is Standard™ doesn't mean it's right for us to do it. Hell, there are plenty of terrible standards, look at some of thesehttp://c2.com/cgi/wiki?BadCodingStandards. You know what the only standard is? Use your brain. Sometimes that will mean following a predefined set of rules and sometimes not. Like I said, it will take some work to get caching working, and right now if we can get by without it, that would be great. If it's a serious problem, then we can address it.

— Sent my iPhone 6 (yes, I have one)

Reply to this email directly or view it on GitHub: https://github.com/Satshabad/Queue-API/issues/9#issuecomment-18433748

Satshabad commented 11 years ago

It was just my snarky way of saying, well if it's so easy, why don't you do it? Then you admit to not knowing how to do it which means you don't really know how simple or complicated it would be to fix. Which is why looked at it, etc.

And yes iPhone 6. Because everyone will have a 5s pretty soon and I can't be someone with just the newest iPhone.