search

Sattva-108 / AdiBags-WoTLK-3.3.5

AdiBags backport with improved UI and functions for 3.3.5 WoTLK client.
13 stars 2 forks source link

Elvui Skins hides Emblems #10

Open Kahuma1 opened 1 week ago

Kahuma1 commented 1 week ago

As said in the title, as long as you have Elvui Addonskins active for Adibags, only Gold is shown, Emblems if selected to be shown in Bags are not shown. bahs

Sattva-108 commented 1 week ago

Thank you I will look into this.

Sattva-108 commented 1 week ago

wow_vNoBPdGHmb

i remember i disabled it bcuz it wasnt working good, needs fixing. now i enabled it and you can see how it looks, need to figure out how to fix all this mess.

  1. it's showing all of them, not only selected.
  2. takes too much space if many is selected.
  3. no images
Sattva-108 commented 1 week ago

i have pushed little fix to the currency-fix branch

https://github.com/Sattva-108/AdiBags-WoTLK-3.3.5/tree/currency-fix

here is direct download link. https://github.com/Sattva-108/AdiBags-WoTLK-3.3.5/archive/refs/heads/currency-fix.zip

commit link: https://github.com/Sattva-108/AdiBags-WoTLK-3.3.5/commit/a11ab575b794403266ef91ad2e0e663549c53152

Sattva-108 commented 1 week ago 
1. it's showing all of them, not only selected.

2. takes too much space if many is selected.

3. no images

1. Toggle which currency/emblems to not show in the:
/adibags Config --> Plugins --> Currency

wow_Z1w6ZusnxK

  1. Problem with spacing - gonna have to be addressed and fixed?

  2. No icons - fixed, partially.

    • currently server that i test on shows all icons correctly, except for Honor and Arena Points
    • if you can confirm honor and arena points not shown correctly on your server either, then i will try to fix it.
Kahuma1 commented 1 week ago

adibags Amount is correct, but the Icons are wrong. Rest seems to be working just fine.

Sattva-108 commented 1 week ago

not addon / server problem with icons, but client-side. i did my best to fix those in the commit: https://github.com/Sattva-108/AdiBags-WoTLK-3.3.5/commit/2cf5be6ef1c24f00a2f75c68b7ae308973c0efda

direct dl link still same. https://github.com/Sattva-108/AdiBags-WoTLK-3.3.5/archive/refs/heads/currency-fix.zip

ty for screenshot!

Kahuma1 commented 1 week ago

Works fine, thanks :D Do you only make bug fixes or are feature request also possible?

Sattva-108 commented 1 week ago

Im glad it works. Feel free to create separate issue for a suggestion.

Is better if one suggestion per one issue. So I can tag some that I can do, and others that I cannot.

This way it will not be forgotten to do.