search

Sattva-108 / AdiBags

AdiBags backport with improved UI and functions for 3.3.5 WoTLK client.
16 stars 2 forks source link

Fonts and ElvUI skin #4

Open Haatmeneer opened 1 year ago

Haatmeneer commented 1 year ago

Please add the option to change the fonts (header, section, items). I'm using ElvUI addonskins, and the items in my bags are not skinned, but in my bank they are. I also tried the retail AdiBags ElvUI skin (https://www.curseforge.com/wow/addons/adibagselvuiskin), but it isn't working at all.

WoWScrnShot_053023_124311

Sattva-108 commented 1 year ago

Hello, thanks for nice feature request! I have backported the Skins tab, and fixed it conflicting with ElvUI, now you can change border, background and font. Big amount of fonts i found in SharedMedia addon, choose what you like :) Hope you will like it man!

As for the Bag Buttons not being changed with AddonSkins (ElvUI): I tried my best to fix it. But that involves looking in ElvUI code which i don't know at all, and as beginner lua developer, took me hours to just try to do this. Didn't work...

I can only say that it's caused because after 3.3.5 - Bag button code is completely written in other ways (even in another file). May be in future i will have better knowledge and try again!

Haatmeneer commented 1 year ago

Thanks for your hard work and quick response/fix. I love adibags, I can't play without it :) Maybe the author of AddonSkins can look at your backport for skinning.

Can I make a another future request? Select font size instead of small/medium/large. I just like pixel perfect fonts... Also, the itemlevel and bag type (mining bags) fonts are not changed.

Thanks again!

Sattva-108 commented 1 year ago

You can give it a try i have added a lot of coding. And yet a lot more code to add to accomplish everything you want. There is one conflict with ElvUI (without ElvUI is fine). Is that you can't manually change Header font color (Backpack text) with ElvUI loaded. To fix that need to disable ElvUI, click reset button and then change color. Then can load ElvUI and be able to changing color without problem. Same for Manual item level color.

As for the mining bags text, its too much complicated to make an option to change it's font. Easiest way would be to make it change same size, font and color as Header or Section fonts. Otherwise need a lot of coding, mistakes fixed and time. Will see if i have motivation for it!

There is however option already to disable that font on items (but not on empty bag slots) - Mining Text. wow_Cqo5sNO4Nw

Gif shows conflict with ElvUI (that can be fixed if you follow instruction above) : dhShkem