search

SaturnFramework / Saturn

Opinionated, web development framework for F# which implements the server-side, functional MVC pattern
https://saturnframework.org
MIT License
714 stars 108 forks source link

Giraffe 3 results in runtime exceptions #141

Closed baronfel closed 5 years ago

baronfel commented 5 years ago

We need to pin the upper bound on the giraffe dependency to be [2.0.0, 3.0.0) because 3.x has some changes to serialization that break at runtime.

And/or we need to update to giraffe 3.0 as well, but fixing the version bound seems easier.

Krzysztof-Cieslak commented 5 years ago

The update to Giraffe 3.0 is definitely planned, I just didn't want to work on it just before the OpenF#.

baronfel commented 5 years ago

No worries, this just came up in slack and I wanted a canonical place to reference.

rmunn commented 5 years ago

Pretty sure https://github.com/SaturnFramework/Saturn/issues/138 will need to be addressed before updating to Giraffe 3.0; I haven't tested it, but I think subroute paths with GUIDs in them might break due to the changes in https://github.com/giraffe-fsharp/Giraffe/issues/282.

Krzysztof-Cieslak commented 5 years ago

Should be fixed in 0.8.0 (#153)