OAuth refactoring - Githubissues

SaturnFramework / Saturn

Opinionated, web development framework for F# which implements the server-side, functional MVC pattern

https://saturnframework.org

MIT License

714 stars 108 forks source link

OAuth refactoring #155

Closed Krzysztof-Cieslak closed 5 years ago

Krzysztof-Cieslak commented 5 years ago

This is proof of concept for the suggestions discussed in https://github.com/SaturnFramework/Saturn/issues/96. CC: @rmunn

Marks use_custom_oauth as obsolete
Adds use_oauth_with_config instead. It's following naming conventions from other authentication methods (use_cookies_authentication_with_config and use_jwt_authentication_with_config).
Adds use_oauth that takes simple record representing the usual OAuth settings and claims.

isaacabraham commented 5 years ago

As this is < v1, maybe consider removing obsolete code than keeping it for backwards compat?

Krzysztof-Cieslak commented 5 years ago

Removing obsolete code is definitely a plan (probably on 1.0 release) but for now I'm OK with keeping it, just to not break too much people already using Saturn in production