search

SaturnFramework / Saturn

Opinionated, web development framework for F# which implements the server-side, functional MVC pattern
https://saturnframework.org
MIT License
708 stars 108 forks source link

Updated giraffe to version 4 #203

Closed brase closed 4 years ago

brase commented 4 years ago

Resolves #201

Maybe I am too naive here but it seems to work.

But I am unsure about the warnings:

C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "Microsoft.Win32.Registry" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\CsrfSample\CsrfSample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Cng" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\CsrfSample\CsrfSample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Pkcs" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\CsrfSample\CsrfSample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Xml" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\CsrfSample\CsrfSample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Permissions" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\CsrfSample\CsrfSample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "Microsoft.Win32.Registry" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Controller.Sample\Controller.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Cng" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Controller.Sample\Controller.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Pkcs" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Controller.Sample\Controller.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Xml" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Controller.Sample\Controller.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Permissions" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Controller.Sample\Controller.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "Microsoft.Win32.Registry" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Saturn.Sample\Saturn.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Cng" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Saturn.Sample\Saturn.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Pkcs" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Saturn.Sample\Saturn.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Xml" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Saturn.Sample\Saturn.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Permissions" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\Saturn.Sample\Saturn.Sample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "Microsoft.Win32.Registry" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\JWTSample\JWTSample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Cng" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\JWTSample\JWTSample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Pkcs" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\JWTSample\JWTSample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Cryptography.Xml" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\JWTSample\JWTSample.fsproj]
C:\Program Files\dotnet\sdk\3.0.100\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3277: Found conflicts between different versions of "System.Security.Permissions" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed. [C:\Users\brase\code\fs\Saturn\sample\JWTSample\JWTSample.fsproj]
brase commented 4 years ago

Found it. The build worked for me because it still used the old version.

Found it. Fixed it. It's green now!

Krzysztof-Cieslak commented 4 years ago

Awesome, I'll take a look at the beginning of the next week.