search

SaturnFramework / Saturn

Opinionated, web development framework for F# which implements the server-side, functional MVC pattern
https://saturnframework.org
MIT License
708 stars 108 forks source link

Remove Microsoft.AspNetCore.Authorization.OAuth for netcore3x? #217

Closed isaacabraham closed 4 years ago

isaacabraham commented 4 years ago

My (limited) understanding is that this is now a framework reference and so perhaps isn't required as a nuget package?

isaacabraham commented 4 years ago

See this https://docs.microsoft.com/en-us/aspnet/core/migration/22-to-30?view=aspnetcore-3.1&tabs=visual-studio#add-package-references-for-removed-assemblies

baronfel commented 4 years ago

Good catch, it should be removed in the 3.x line 👍

isaacabraham commented 4 years ago

I've created an experimental repo to highlight the reductions that are possible:

  1. Removing Authorization and Auth packages: https://github.com/CompositionalIT/saturn-deps/commit/f8be21a30a066af625bb25362b4fe103e4b513e2
  2. Once Giraffe 3 is released (and if we accept TaskBuilder 2.2 alpha): https://github.com/CompositionalIT/saturn-deps/commit/6acf0025bc1a392fed9a0d236f29d47d801179c2.

This will leave us with a 64 line paket lock file, down from 307 lines.