SaturnFramework / Saturn

Opinionated, web development framework for F# which implements the server-side, functional MVC pattern
https://saturnframework.org
MIT License
715 stars 109 forks source link

Channel improvements #233

Closed Krzysztof-Cieslak closed 4 years ago

Krzysztof-Cieslak commented 4 years ago
Krzysztof-Cieslak commented 4 years ago

CC: @baronfel @robertpi @isaacabraham

baronfel commented 4 years ago

I like these changes a lot. Obviously docs are great, but the typed message handlers are nice as well. One thing that I see being challenging is people wanting to model channel messages as DUs and then running into deserialization errors.

Krzysztof-Cieslak commented 4 years ago

channel messages as DU

Well, it’s problem everywhere - in controllers, in normal http handlers. And it depends - channels are using same IJSonSerializer as any other feature so the behavior should be consistent

robertpi commented 4 years ago

Looks good to me, all I was doing was using the json serialize to deszeialize the message, so will save me a few lines.