SaturnFramework / Saturn

Opinionated, web development framework for F# which implements the server-side, functional MVC pattern
https://saturnframework.org
MIT License
702 stars 108 forks source link

sample/ChannelsSample throws error on join #379

Open Tweega opened 4 months ago

Tweega commented 4 months ago

I get the following error:

server:       An unhandled exception has occurred while executing the request.
server:       System.MissingMethodException: Method not found: 'System.IO.MemoryStream Microsoft.IO.RecyclableMemoryStreamManager.GetStream()'.  
server:          at FSharp.Control.Websockets.ThreadSafeWebSocket.receiveMessageAsUTF8@664-6.Invoke(Unit unitVar)
server:          at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvoke[T,TResult](AsyncActivation`1 ctxt, TResult result1, FSharpFunc`2 part2) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 510
server:          at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in D:\a\_work\1\s\src\FSharp.Core\async.fs:line 112    
server:       --- End of stack trace from previous location ---
server:          at Saturn.Channels.Invoke@109.MoveNext()
server:          at Giraffe.Middleware.Invoke@63-1.MoveNext()

If this works for anyone else, would it be possible to see the paket.lock file?

rastreus commented 3 months ago

This error was a versioning error of Microsoft.IO.RecyclableStreams in FSharp.Control.Websockets.

This has since been fixed with a new release of FSharp.Control.Websockets: https://github.com/TheAngryByrd/FSharp.Control.WebSockets/releases/tag/v0.3.0


@forki When you have availability, can the dependency version for FSharp.Control.Websockets please be updated to 0.3 in the paket.dependencies file:

https://github.com/SaturnFramework/Saturn/blob/8511856ba3121aad62902ccc9571b7976146198f/paket.dependencies#L20

And then publish a new v0.16.2 Release of Saturn?

rastreus commented 2 months ago

Thank you for the v0.17 Release, @baronfel.

baronfel commented 2 months ago

Oh, does this still need the 0.3 update of FSharp.Control.WebSockets? If you could send a PR with that change @rastreus I'd be happy to do another release.