Closed zualexander closed 3 years ago
pls tell me if I did something wrong, or I should adapt the PR :)
closes #157
do you want me to change the 'defaultColor' to an '@Input'?
@SaturnTeam Could you have a look ? Thanks !
I switched to default mat-datepicker. https://material.angular.io/components/datepicker/overview#date-range-input-forms-integration
This awesome date picker is currently unusable with Angular Material 10. It would be so great if you could merge this simple change so we can upgrade our apps to Angular Material 10.
Hi, I tried to install the new version with npm (8.0.6), but I didn't found it. Can you release the new version? Thanks to great work done!
I'm sorry, I'm not a contributor of this repo, I just added this quickfix as a PR. @SaturnTeam can you do the release? :)
@SaturnTeam Thanks for merging the fix. Any ETA for a new NPM release including this? Really looking forward to it so I can upgrade our app to Angular 10.
I use Angular 10, and i have the same problem. any solution?
We switched back to the builtin Angular Material date picker which, starting with version 10, also supports date ranges which was our initial reason to use the Saturn Date picker.
davidoween notifications@github.com schrieb am Di., 23. Feb. 2021, 09:57:
I use Angular 10, and i have the same problem. any solution?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SaturnTeam/saturn-datepicker/pull/156#issuecomment-784015799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVZVIWUWH3RCOD5DYI6QJ3TANUW7ANCNFSM4Q6DNQ3A .
We switched back to the builtin Angular Material date picker which, starting with version 10, also supports date ranges which was our initial reason to use the Saturn Date picker. davidoween notifications@github.com schrieb am Di., 23. Feb. 2021, 09:57: … I use Angular 10, and i have the same problem. any solution? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#156 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVZVIWUWH3RCOD5DYI6QJ3TANUW7ANCNFSM4Q6DNQ3A .
I need a inline datepicker .
there is no solution?
Not sure and will verify tomorrow. But I got the feeling there are 2 published packages: saturn-datepicker and saturn-datepicker-ext. The latter one seems to have the fix but not the former one which I actually use. If anybody has a chance to try before I do. I am off for today :)
And it seems that @angular/material v11.2.2 now offers to pick a range: https://material.angular.io/components/datepicker/overview#date-range-selection
I confirm. I used the npm package saturn-datepicker-ext instead of saturn-datepicker and everything is working fine on my end. Will replace that by the newly supported range picker from angular material v11.2.2 soon.
with angular 10.2. the build breaks:
`ERROR in node_modules/saturn-datepicker/datepicker/datepicker.d.ts:57:22 - error TS2420: Class 'SatDatepicker' incorrectly implements interface 'CanColor'.
Property 'defaultColor' is missing in type 'SatDatepicker' but required in type 'CanColor'.
57 export declare class SatDatepicker implements OnDestroy, CanColor {