search

SaturnTeam / saturn-datepicker

Angular Material Datepicker with range selection
MIT License
278 stars 110 forks source link

fix: remove unnecessary moduleId: module.id #160

Closed ThibaudAV closed 3 years ago

ThibaudAV commented 3 years ago

I have run the application everything seems to work correctly. The build of the lib works too

WillGeller commented 3 years ago

Thanks for doing this fix! Is it available on the NPM release at the moment or will it be going into the next patch @ https://www.npmjs.com/package/saturn-datepicker?activeTab=versions soon?

SaturnTeam commented 3 years ago

No. Because I have to compile the lib before publish. And I cannot compile due to using old ng-packgr.

WillGeller commented 3 years ago

I see, is that going to postpone releasing new updates to this library then? This issue is a blocker on my team being able to use it, but we are in Angular 8 so can't use the official version and would like to use yours. Let me know if I can help in anyway.

On Thu, Oct 8, 2020, 4:15 PM SaturnTeam notifications@github.com wrote:

No. Because I have to compile the lib before publish. And I cannot compile due to using old ng-packgr.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SaturnTeam/saturn-datepicker/pull/160#issuecomment-705799117, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSV2QRMRBFEEBXGZPXHLATSJYMXPANCNFSM4SBPXDBA .

SaturnTeam commented 3 years ago

Anyway, next version would be for Angular 10, so I recommend to copy code from repository or upgrade to Angular 10