API entry_get_actor_overview doesn't work

[GoogleCodeExporter]

The API call entry_get_actor_overview incorrectly passes "offset" argument
to entry_get_inbox which since_time.

Patch attached.

What version of the product are you using? On what operating system?
Revision 40

Please provide any additional information below.
This currently affects jaiku.com service as well. If someone knows, please
advice on whether I should contact jaiku.com or not.

Original issue reported on code.google.com by amr.most...@gmail.com on 2 Apr 2009 at 11:18

Attachments:

• jaiku_api_entry_offset.patch

[GoogleCodeExporter]

Can you please send the patch to http://rietku.appspot.com/ ?

Thanks!

Original comment by tony.t.t...@gmail.com on 4 Apr 2009 at 5:36

[GoogleCodeExporter]

Done! http://rietku.appspot.com/3009

Original comment by amr.most...@gmail.com on 4 Apr 2009 at 8:34

[GoogleCodeExporter]

Original comment by andyster on 22 Apr 2009 at 11:21

• Changed state: WorksForMe

[GoogleCodeExporter]

I think the issue here is the word "offset". When I see the word "offset", I
automatically associate it with the offset keyword in sql. Without reading the 
doc
closely, I'd assume the offset parameter indicates the number of entries to skip
before returning the result.

How about renaming the parameter to something like "before_time"? While we're 
here,
maybe deprecate entry_get_actor_overview and replace it with
entry_get_actor_overview_before?

Original comment by tony.t.t...@gmail.com on 1 May 2009 at 8:51

• Changed state: Accepted

[GoogleCodeExporter]

I'm a bit ambivalent towards changing the name of the argument. On one hand it 
is
more clear, on the other I don't think the existing usage is particularly 
confusing

Original comment by andyster on 19 May 2009 at 1:11

[GoogleCodeExporter]

I'll mention this when updating the api doc.

Original comment by tony.t.t...@gmail.com on 5 Jun 2009 at 8:34

• Changed state: Duplicate