Satyam1923 / Spring-Music-Player

The Spring Music Player project aims to create a feature-rich music player application leveraging the multiple APIs. This application will provide users with a seamless experience to discover, stream, and organize their favorite music tracks from the extensive library.
https://spring-music-player.vercel.app/
MIT License
63 stars 140 forks source link

Feat:container box and text is overriding #366

Open Garima-149 opened 2 weeks ago

Garima-149 commented 2 weeks ago

Describe the feature

In the provided screenshot,The spring text and container box is overriding.This is distorting UI of landing page . @Satyam1923 I would like to work on this issue.PLease assign me this,thankyou.

Add ScreenShots

Screenshot (56)

Record

github-actions[bot] commented 2 weeks ago

Congratulations, @Garima-149! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work! As per GSSoC'24 guidelines the person who raises the issue should be assigned for that issue. But if that person doesn't want to work on that issue the first come fist policy is follwed.

We'd also like to invite you to our Discord server! Join us on discord.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Satyam1923 commented 2 weeks ago

@Garima-149 fine .

Garima-149 commented 2 weeks ago

@Satyam1923 Screenshot (58) Screenshot (59)

I have done the change but when I tried to open the server.Although,server is opening but I am unable to see tha app,frontend or backend anything.Please help me with this.

Satyam1923 commented 2 weeks ago

@Satyam1923 Screenshot (58) Screenshot (59)

I have done the change but when I tried to open the server.Although,server is opening but I am unable to see tha app,frontend or backend anything.Please help me with this.

@Garima-149 make a new project in firebase and copy its firebase config in firebase.js If you still need help contact me in discord I'll provide the config file.

Garima-149 commented 2 weeks ago

Actually I haven't tried firebase yet.So,I don't know ,how to deal with it.

Satyam1923 commented 2 weeks ago

Actually I haven't tried firebase yet.So,I don't know ,how to deal with it.

Fine just msg me on discord I'll tell you the steps and config.

Garima-149 commented 2 weeks ago

Screenshot (60) @Satyam1923 Now,the text is not overriding.Please check it.Should I raise pr?

Satyam1923 commented 2 weeks ago

Could fix the weeknd and plays text also.

Garima-149 commented 2 weeks ago

Could fix the weeknd and plays text also.

At which side of page?

Satyam1923 commented 2 weeks ago

Above genres and top artists.

Garima-149 commented 2 weeks ago

Screenshot (61) @Satyam1923 Check it once.Also,please tell should I raise PR or need changes?

Satyam1923 commented 2 weeks ago

@Garima-149 isn't it going above footer.

Garima-149 commented 2 weeks ago

Screenshot (62)

@Satyam1923 Now please check.Any further changes required?

Satyam1923 commented 2 weeks ago

@Garima-149 now check top artists row it's clashing with recent played.

Garima-149 commented 2 weeks ago

Screenshot (63) @Satyam1923 Now ,is it fine?

Satyam1923 commented 2 weeks ago

fine add more spacing.

Garima-149 commented 2 weeks ago

fine add more spacing.

everywhere? or just above Top Artists side?

Satyam1923 commented 2 weeks ago

Between every elements such top artists row genres row provide a good space between them.

Garima-149 commented 2 weeks ago

Screenshot (64) @Satyam1923 This much space is fine? I have also equalized the length of right card body with left body .

Satyam1923 commented 2 weeks ago

ya fine.

Garima-149 commented 2 weeks ago

@Satyam1923 Should I add that code which I inserted in its firebase file?or not while raising PR.

Satyam1923 commented 2 weeks ago

@Garima-149 what does it contain anyway.

Garima-149 commented 2 weeks ago

Screenshot (65) Should I add this code or remove it while making PR?

Satyam1923 commented 2 weeks ago

No remove this code.